refactor: drop disableAutoFocus naming in favor of focusOnHover#879
Open
harrrshall wants to merge 1 commit into
Open
refactor: drop disableAutoFocus naming in favor of focusOnHover#879harrrshall wants to merge 1 commit into
harrrshall wants to merge 1 commit into
Conversation
The disableAutoFocus prop has already been superseded by focusOnHover
throughout the component code. This updates the last remaining vestige:
the DisabledAutoFocus board fixture is renamed to FocusOnHoverDisabled
and now explicitly passes focusOnHover={false} so it actually exercises
the prop.
Closes tscircuit#163
harrrshall
requested review from
Abse2001,
ShiboSoftwareDev and
seveibar
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #163
The
disableAutoFocusprop has already been replaced byfocusOnHoverthroughout the component code (PCBViewer,CanvasElementsRenderer,DimensionOverlay). The only remaining trace of the olddisableAutoFocusnaming was theDisabledAutoFocusboard fixture.This PR:
DisabledAutoFocusfixture toFocusOnHoverDisabled.focusOnHover={false}, so the fixture actually exercises the prop instead of relying on the implicit default./claim #163