Handle undefined route returns with helpful guidance#158
Open
CharlieLZ wants to merge 1 commit into
Open
Conversation
Author
|
Ready for review. This PR adds explicit guidance for route handlers that resolve to undefined, with focused coverage for the regression case.\n\nVerification run locally:\n- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undefined.statusctx.json({...})or return aResponseWhy
Current
mainstill allowsundefinedroute returns to reachserializeResponse, where.statusis read before the existing raw-object guidance middleware can run. That produces a low-level serialization failure instead of the issue #30 guidance.This is narrower than the raw-object case and keeps existing
return { ... }behavior intact.Verification
npm test -- tests/errors/do-not-allow-raw-json.test.ts-> 2 passednpm run lint-> passednpm run typecheck-> passednpm test-> 186 passed, 18 skipped/claim #30