Support filling content field from file + update dependencies#153
Open
ILikePlayingGames wants to merge 5 commits intotsickert:masterfrom
Open
Support filling content field from file + update dependencies#153ILikePlayingGames wants to merge 5 commits intotsickert:masterfrom
ILikePlayingGames wants to merge 5 commits intotsickert:masterfrom
Conversation
- Add option to send text from a text file in the content field - Update dependencies - Fix jest tests not being linted
tsickert
approved these changes
Mar 26, 2024
Owner
tsickert
left a comment
tsickert
left a comment
There was a problem hiding this comment.
Nice idea, thanks for the testing/linting updates too!
Stanzilla
reviewed
Apr 2, 2024
| "eslint-plugin-github": "^4.3.2", | ||
| "eslint-plugin-jest": "^25.3.2", | ||
| "jest": "^27.2.5", | ||
| "@types/node": "^18.14.6", |
There was a problem hiding this comment.
this should probably be 20 since it's LTS
Contributor
Author
|
Thanks! Sorry Ive been quite busy recently so I cant fix the conflicts yet. I’ll try to look at it when I have some time. |
…ntent # Conflicts: # .eslintignore # .github/workflows/test.yml # dist/index.js # dist/index.js.map # jest.config.cjs # package-lock.json # package.json # tsconfig.json
Contributor
Author
|
Sorry I took a while. The conflicts are fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading content from a file instead of step output or env var is useful for cases where the content has special characters that those means cannot handle. One such case is posting ANSI coloured text, which has escape codes.