Skip to content

bpf, arm64: fix bpf line info#1879

Open
tsipa wants to merge 3 commits intobpf-nextfrom
series/608638=>bpf-next
Open

bpf, arm64: fix bpf line info#1879
tsipa wants to merge 3 commits intobpf-nextfrom
series/608638=>bpf-next

Conversation

@tsipa
Copy link
Copy Markdown
Owner

@tsipa tsipa commented Feb 8, 2022

Pull request for series with
subject: bpf, arm64: fix bpf line info
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002

@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 8, 2022

Master branch: 128dac5
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 8, 2022

Master branch: 80123f0
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 36f310a to 84880c0 Compare February 8, 2022 02:23
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 8, 2022

Master branch: 5d1e9f4
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 84880c0 to 421053a Compare February 8, 2022 02:35
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 8, 2022

Master branch: f95f768
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 421053a to 7cf47bf Compare February 8, 2022 17:31
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 8, 2022

Master branch: 5912fcb
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 7cf47bf to 660194b Compare February 8, 2022 20:32
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 8, 2022

Master branch: 4172843
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 660194b to b328c09 Compare February 8, 2022 21:41
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 8, 2022

Master branch: 19face1
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 9, 2022

Master branch: cca6242
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from d7b80e0 to 0a3139f Compare February 9, 2022 02:40
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 9, 2022

Master branch: 8dd039a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 0a3139f to 150251e Compare February 9, 2022 05:43
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 9, 2022

Master branch: 3caa7d2
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 150251e to b34119e Compare February 9, 2022 05:50
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 9, 2022

Master branch: dc37dc6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from b34119e to 2d82cf1 Compare February 9, 2022 13:40
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 9, 2022

Master branch: e531396
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 2d82cf1 to 5ba0450 Compare February 9, 2022 20:01
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 10, 2022

Master branch: 1127170
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 5ba0450 to d902bd2 Compare February 10, 2022 05:20
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 10, 2022

Master branch: 85fbd23
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from d902bd2 to a4f08fb Compare February 10, 2022 22:36
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 11, 2022

Master branch: a5a358a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from a4f08fb to 1d3b30c Compare February 11, 2022 01:55
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 11, 2022

Master branch: 4cc0991
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 1d3b30c to c13676b Compare February 11, 2022 03:03
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 11, 2022

Master branch: 4407fa0
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from c13676b to 7ef4fe5 Compare February 11, 2022 05:18
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 11, 2022

Master branch: d130e95
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 7ef4fe5 to 85731b1 Compare February 11, 2022 21:01
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 12, 2022

Master branch: 9c3de61
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 85731b1 to 0f62ae8 Compare February 12, 2022 16:09
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 15, 2022

Master branch: edc21dc
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 0f62ae8 to 78ae1dd Compare February 15, 2022 17:25
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 15, 2022

Master branch: d2b94f3
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

@tsipa tsipa force-pushed the series/608638=>bpf-next branch from 78ae1dd to da5c0b7 Compare February 15, 2022 18:08
@tsipa
Copy link
Copy Markdown
Owner Author

tsipa commented Feb 15, 2022

Master branch: 8cbf062
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=612002
version: 3

Nobody and others added 3 commits February 15, 2022 10:11
BPF line info needs ctx->offset to be the instruction offset
in the whole jited image instead of the body itself, so also
call build_prologue() first in first JIT pass.

Fixes: 37ab566 ("bpf: arm64: Enable arm64 jit to provide bpf_line_info")
Signed-off-by: Hou Tao <houtao1@huawei.com>
insn_to_jit_off passed to bpf_prog_fill_jited_linfo() is calculated
in instruction granularity instead of bytes granularity, but bpf
line info requires byte offset, so fixing it by calculating ctx->offset
as byte-offset. bpf2a64_offset() needs to return relative instruction
offset by using ctx->offfset, so update it accordingly.

Fixes: 37ab566 ("bpf: arm64: Enable arm64 jit to provide bpf_line_info")
Signed-off-by: Hou Tao <houtao1@huawei.com>
@tsipa tsipa force-pushed the series/608638=>bpf-next branch from da5c0b7 to ca58c42 Compare February 15, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant