[FIX] destination buffer of galois_wxx_region_multiply#21
Open
TaranovK wants to merge 1 commit into
Open
Conversation
The manual says that if the dest buffer is NULL, then the result of multiplication will go to the source region buffer. However, multiply_region.w32 function, which is called by galois_wxx_region_multiply, assumes that the destination buffer is not NULL. The proposed fix assigns destination buffer to source buffer if destination buffer is NULL.
Author
|
The second possible solution can be: |
Owner
|
So, this repo has been around forever because I was the first person who took Dr. Plank's code and posted it to github, but I've never really maintained it; it was pretty much just an easier way to browse the code than his tar archives. Could you submit this patch to Jerasure's gitlab at http://lab.jerasure.org/jerasure/jerasure ? I think it will get better attention there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manual says that if the dest buffer is NULL, then the result of
multiplication will go to the source region buffer. However,
multiply_region.w32 function, which is called by galois_wxx_region_multiply,
assumes that the destination buffer is not NULL.
The proposed fix assigns destination buffer to source buffer if destination buffer is NULL.