Add headers to REST error object #472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Twitter provides rate limit information via custom HTTP headers on each request, but, as of commit 8fcea75, the promise interface no longer exposes the full response from Twitter, so this info is no longer available from 4xx or 5xx responses.
Solution: Attach the headers to the error in the same way that the response body and status code are attached. Since this is relevant metadata for managing Twitter requests, it makes sense to me to include this here, and it shouldn't be too much noise. I also considered attaching the full response to the error object, but that felt excessive. I'm open to discussion either way, though. Thanks for all your work on this!