[source_ref] include the ending line of a log statement#13
Merged
Conversation
If a log statement is broken up over multiple lines, the user might refer to any of those lines when setting a breakpoint. So, we need to include the ending line number in the SourceRef. Files: * lib.rs: Add a method to get the StatementsInFile object from the LogMatcher. This is needed to handle a breakpoint request. Also, adjust the java tree-sitter query so template strings are handled using Named placeholders. * source_hier.rs: Completely ignore some directories in the source hierarchy, like version control ones. Add methods to find a file in the source hierarchy. * source_query.rs: Only return results from captures after the format string. * source_ref.rs: Add ending line number. * test_java.rs: Add a java test that uses slf4j-style log statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a log statement is broken up over multiple lines, the user might refer to any of those lines when setting a breakpoint. So, we need to include the ending line number in the SourceRef.
Files: