[progress] add support for polling the ProgressListener with a timeout#14
Merged
Conversation
There's a thread in lnav that needs to poll for progress and can't block waiting for an update.
If multiple regexes match a message, we should prefer
the one with the most non-whitespace surrounding
text. For example, between "Hello, {name}!" and
"{salutation}, {name}!", we should prefer the "Hello"
version when matched since that is more specific.
Files:
* lib.rs: Sort the matched SourceRefs by their
quality. Refine the rust query to ignore some
macros, allow for qualified macro names, and
capture only the first literal since a literal
arg might be used when there's an alignment (e.g.
`log::debug!("foo {:16} {}", "bar", baz)`).
* source_query.rs: Only return a sibling result if
it is non-zero in length.
* source_ref.rs: Add quality field.
ttiimm
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a thread in lnav that needs to poll for
progress and can't block waiting for an update.