[tests] switch to using insta for handling expected results#2
Merged
Conversation
ttiimm
approved these changes
Sep 3, 2025
| let normalized = if path_sep == '/' { | ||
| path_str.to_string() | ||
| } else { | ||
| // On Windows, swap the forward slash for backslashes |
Owner
There was a problem hiding this comment.
Any thoughts on how to make the tests cross platform?
Contributor
Author
There was a problem hiding this comment.
There's a "Redactions" feature that might help -- https://insta.rs/docs/redactions/
Contributor
Author
|
I'm not sure why the actions failed. Do they need some tweaking to work with PRs? |
Owner
Yeah, think I have this fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The insta library seems like a reasonable way to do snapshot testing. Changing this first so I can make sense of test failures as I do other things.