Conversation
This commit is seeded to the public domain under CC0 1.0 International, however you may use it under the terms of the MIT-0, often because your organisation does not recignise CC0.
tryoxiss
requested changes
Apr 5, 2024
tryoxiss
left a comment
tryoxiss
left a comment
Collaborator
There was a problem hiding this comment.
Looks mostly good, however you forgot to add specific details in the MIT. Its not needed in the apache (I dont know if they want you to do it) because its not part of the licence deed, its just a footnote, but its defintely what people do with the MIT.
…s enabled by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation for #5.
This change includes the following: