Bump TerminalGuiVersion to 2.4.18-develop.0 (needs fixes)#274
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79b5344f4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets). | ||
| --> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.17-develop.14</TerminalGuiVersion> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.18-develop.0</TerminalGuiVersion> |
There was a problem hiding this comment.
Include the compatibility fixes before bumping TG
This raises the default TerminalGuiVersion to 2.4.18-develop.0, but this exact automated bump was opened as a failed-validation bump (needs fixes), meaning the current source/tests do not pass against the new Terminal.Gui floor. Any normal restore/build that does not override this property now consumes the broken dependency version, so this should either stay at the last green pin or include the source/test changes needed to absorb the Terminal.Gui update.
Useful? React with 👍 / 👎.
Automated bump of
TerminalGuiVersionfrom2.4.17-develop.14to2.4.18-develop.0failed validation (build or tests).Editor needs source changes to absorb this Terminal.Gui update. See the
failed workflow run.