Skip to content

Fetch gateway does not normalize HTTP method casing, leading to request issues with undici #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juniorvanin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fetch gateway does not normalize HTTP method casing, leading to request issues with undici #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6af962
normalize fetch gateway method
Apr 23, 2025
74bc955
Add changeset
Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-chefs-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'mappersmith': patch
---

Update the performRequest method in the Fetch gateway to normalize the HTTP method to uppercase to mitigate issue with PATCH calls and undici
Copy link
Copy Markdown
Collaborator

@klippx klippx Apr 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Update the performRequest method in the Fetch gateway to normalize the HTTP method to uppercase to mitigate issue with PATCH calls and undici
Update the `performRequest` method in all gateways to normalize the HTTP method to uppercase. This is to ensure users of mappersmith can continue to use lowercase methods in their manifest and still be compatible with fetch libraries that are equipped with a case sensitive fetch mechanism.

4 changes: 2 additions & 2 deletions src/gateway/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class Fetch extends Gateway {
}

const customHeaders: Record<string, string> = {}
const body = this.prepareBody(requestMethod, customHeaders)
const body = this.prepareBody(requestMethod.toUpperCase(), customHeaders)
const auth = this.request.auth()

if (auth) {
Expand All @@ -66,7 +66,7 @@ export class Fetch extends Gateway {
}

const headers = assign(customHeaders, this.request.headers())
const method = this.shouldEmulateHTTP() ? 'post' : requestMethod
const method = this.shouldEmulateHTTP() ? 'POST' : requestMethod.toUpperCase()
Copy link
Copy Markdown
Collaborator

@klippx klippx Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same should be done in two more files, I know this was originally only for Fetch gateway but the way I see it this is not about your specific case and changing Fetch to be different just because of undici:

  • src/gateway/http.ts
  • src/gateway/xhr.ts

const userSignal = this.request.signal()

// Since 1) node fetch requires timeout to be handled via abort controller and 2) we support an external user signal, we need to merge them:
Expand Down
Loading