Order metadata by groupId#535
Open
michaeljs1990 wants to merge 1 commit intotumblr:masterfrom
michaeljs1990:lshw-ordering-bug
Open
Order metadata by groupId#535michaeljs1990 wants to merge 1 commit intotumblr:masterfrom michaeljs1990:lshw-ordering-bug
michaeljs1990 wants to merge 1 commit intotumblr:masterfrom
michaeljs1990:lshw-ordering-bug
Conversation
This orders metadata by the groupId of that metadata before passing it onto other functions for processing. Since a Map was previously used you could end up with your data being rendered in any which order. Now data provided you map it correctly in the following functions will be displayed in the proper order. Report: #534
Contributor
Author
|
All tests still pass but someone else should look at this as i'm not sure if it could have other subtle effects. |
Contributor
|
This LGTM, but I would definitely like unit tests to ensure expected behavior. Can you contrive a fixture lshw/lldp that illustrates the behavior? |
Contributor
|
@michaeljs1990 bump, checking on unit tests. Is this merge blocking anything internal for you? |
Contributor
Author
|
No this one is not. I was actually just bored that night so I tried to fix the issue in #534 since it sounded interesting. I'll likely get some unit tests added for this over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This orders metadata by the groupId of that metadata before passing it
onto other functions for processing. Since a Map was previously used you
could end up with your data being rendered in any which order. Now data
provided you map it correctly in the following functions will be displayed
in the proper order.
TODO:
Report: #534