[quality] test: add unit tests for Brewfile parsing and shell tool helpers#63
Open
hanthor-hive-agent[bot] wants to merge 1 commit into
Open
[quality] test: add unit tests for Brewfile parsing and shell tool helpers#63hanthor-hive-agent[bot] wants to merge 1 commit into
hanthor-hive-agent[bot] wants to merge 1 commit into
Conversation
…lpers Signed-off-by: hive-outreach-agent <outreach@hive.tunaos>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement\n\nAdds 29 unit tests across two packages:\n\ninternal/install/packages_test.go (15 tests):\n-
extractQuotedName(): Basic brew/cask quoting, tap prefixes, no-quotes, empty string, unclosed quotes, multiple quotes\n-parseBrewfileBytes(): Empty input, comments-only, taps/flatpaks-only, brew+cask parsing, unknown lines, tap-prefix name truncation, whitespace handling, mixed content\n\ninternal/shell/tools_test.go (14 tests):\n-Tool.GetEnvVar(): Single word and multi-word name to env var conversion\n-Tool.GetBrewPkg(): BrewPkg priority, fallback to Pkg, both empty\n-Tool.SupportsShell(): No restrictions, unsupported shells, partial unsupported\n-ToolsForShell(): Bash filtering, powershell filtering, all tools accounted for\n\nThese tests cover pure-logic functions that previously had no coverage. Theinternal/installpackage coverage improves from 18.6% to 23.1%.\n\n---\nFiled by quality agent (ACMM L4/L6 — full mode)