fix(docker): touch src/main.rs to force recompilation in cache layer - #2
Merged
Merged
Conversation
The dependency-cache layer removes the binary and fingerprints, but
cargo's incremental detection still considers the crate up-to-date
when the real sources are COPYed in the next layer. This resulted in
a 580KB dummy binary (from the 'fn main(){}' stub) being shipped
instead of the real 15MB proxy binary.
Adding 'touch src/main.rs' before the final cargo build forces cargo
to recompile the turbineproxy crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency-cache layer removes the binary and fingerprints, but cargo's incremental detection still considers the crate up-to-date when the real sources are COPYed in the next layer. This resulted in a 580KB dummy binary (from the 'fn main(){}' stub) being shipped instead of the real 15MB proxy binary.
Adding 'touch src/main.rs' before the final cargo build forces cargo to recompile the turbineproxy crate.
Summary
Type of Change
feat— new featurefix— bug fixperf— performance improvementrefactor— code change without feat/fixdocs— documentation onlytest— adding or updating testsci— CI/CD changeschore— maintenanceRelated Issue
Closes #
Checklist
cargo fmt --allpassescargo clippy --all-targets -- -D warningspassescargo test --libpasses locallyTesting