Fix "upload has been aborted" error#10863
Merged
Merged
Conversation
"improve upload speed" (b17d491) commit introduced a change to xhr.upload.onabort handler to throw a `CancelledError`. In case of a timeout the request is also aborted but should be treated as a network error instead. We've changed the handler to be the same as in `xhr.onabort()`. This also fixes missing timeout reset. Close tuta#3511
- renewed timeout ID was incorrect for binary uploads - logged request id was incorrect - reject() could have been called multiple times Also do small cleanup for body timeout
charlag
force-pushed
the
drive/3511-restclient-upload-abort
branch
from
7a43f17 to
4a1c1d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.