Fix MVC DPB slot aliasing between base and dependent views#23
Open
intrepidsilence wants to merge 1 commit intotvlabs:masterfrom
Open
Fix MVC DPB slot aliasing between base and dependent views#23intrepidsilence wants to merge 1 commit intotvlabs:masterfrom
intrepidsilence wants to merge 1 commit intotvlabs:masterfrom
Conversation
When decoding MVC streams, the DPB slot allocator can assign the dependent view to the same slot as the base view (basePic). Since the dependent view references the base view's pixels for inter-view prediction, this overwrites the reference data and corrupts the dependent view's decoded output. Add basePic to the unavailability bitmask when allocating a slot for a dependent view frame. The check is placed after the existing while loop (not inside it) to avoid potential issues if basePic were the only nominally free slot. Symptom: bright rectangular artifact blocks (~8x6 macroblocks) appear at variable positions in the MVC dependent view output. Verified on commercial 3D Blu-ray MVC streams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When decoding MVC streams, the DPB slot allocator can assign the dependent view to the same slot as the base view (
basePic). Since the dependent view references the base view's pixels for inter-view prediction, this overwrites the reference data and corrupts the dependent view's decoded output.Fix
Add
basePicto the unavailability bitmask when allocating a slot for a dependent view frame (line ~1137 ofedge264_headers.c):The check is placed after the existing
whileloop (not inside it) to avoid potential issues ifbasePicwere the only nominally free slot.Symptom
Bright rectangular artifact blocks (~8x6 macroblocks) appear at variable positions in the MVC dependent view output. The artifacts correspond to macroblocks where the dependent view reads from its own overwritten buffer instead of the base view's original pixels.
Verification