Open
Conversation
Open
Owner
|
are the changes complete? |
|
would love to use this as well for py3. @tarekziade anything I can do to help? |
Author
|
Hey @jeffbryner - sorry I dropped that work. I guess my branch would need to be refreshed with the latest Flask and should work, if you are interested in picking up the work. Full disclosure: I am not involved right now in any Flask-based project |
|
No worries, I took a shot at it as well using 2to3 then trying to correct the tests but honestly I couldn't figure out why some of the tests were failing. There's some magic going on with the header ordering that I couldn't figure out. I pivoted to manually setting headers. Hopefully someone else will have better luck. |
|
@twaldear - Are you in chat with others on this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the lib, I am planning to use it on a python 3 project.
If you are interested in my changes:
My next step is to make it pass the flake8 standard and finish fixing the tests, if you are interested in this contribution.
Cheers!