Skip to content

Polish: lint cleanup, hygiene, CI gate, README - #1

Merged
twimart merged 6 commits into
mainfrom
polish/lint-hygiene-ci
Sep 14, 2026
Merged

twimart merged 6 commits into
mainfrom
polish/lint-hygiene-ci

Conversation

@twimart

@twimart twimart commented Sep 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

Polish pass for lint cleanliness, repo hygiene, CI quality gate, and docs. Not merged.

1. Lint cleanup

  • Verified listed components use motion via JSX (motion.div etc.). ESLint’s no-unused-vars does not count JSX member expressions as usage (same reason the Vite template ignores PascalCase).
  • Updated eslint.config.js:
    • varsIgnorePattern now also allows motion
    • react-refresh/only-export-components allows useLang (standard LangProvider + hook export)
  • Fixed Hero.jsx react-hooks/set-state-in-effect properly (no eslint-disable):
    • CountUp: derive static value when not animating; start animation from inside requestAnimationFrame
    • TypewriterText: advance delete→next via setTimeout; remount on lang change with key={lang} (removed reset effect)

2. Repo hygiene

  • Deleted public/profile.jpeg~ (~2.5MB junk backup)
  • Skipped compressing public/smart-recipe.png (no pngquant/optipng/imagemagick available)

3. CI quality gate

  • Updated .github/workflows/deploy.yml:
    • Also runs on pull_request to main
    • Runs npm run lint then npm run build
    • Uploads Pages artifact + deploys only on push/workflow_dispatch to main (PRs get lint+build only)

4. README

  • Replaced stock Vite README with portfolio-specific docs (thomaswimart.fr, stack, commands, content paths).

Local verification

  • npm run lint — clean
  • npm run build — success

Test plan

  • Confirm lint/build pass on this PR’s Actions run
  • Spot-check Hero count-up + typewriter (incl. FR/EN toggle)
  • After merge: confirm Pages deploy still works on main

@twimart twimart changed the title Polish: lint cleanup, Hero effect fixes, hygiene, README Polish: lint cleanup, hygiene, CI gate, README Sep 14, 2026
@twimart
twimart merged commit d3c7262 into main Sep 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant