Repository navigation
Polish: lint cleanup, hygiene, CI gate, README - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polish pass for lint cleanliness, repo hygiene, CI quality gate, and docs. Not merged.
1. Lint cleanup
motionvia JSX (motion.divetc.). ESLint’sno-unused-varsdoes not count JSX member expressions as usage (same reason the Vite template ignores PascalCase).eslint.config.js:varsIgnorePatternnow also allowsmotionreact-refresh/only-export-componentsallowsuseLang(standard LangProvider + hook export)Hero.jsxreact-hooks/set-state-in-effectproperly (no eslint-disable):requestAnimationFramesetTimeout; remount on lang change withkey={lang}(removed reset effect)2. Repo hygiene
public/profile.jpeg~(~2.5MB junk backup)public/smart-recipe.png(no pngquant/optipng/imagemagick available)3. CI quality gate
.github/workflows/deploy.yml:pull_requesttomainnpm run lintthennpm run buildworkflow_dispatchtomain(PRs get lint+build only)4. README
Local verification
npm run lint— cleannpm run build— successTest plan