Repository navigation
Close the launcher when its monitor disconnects - #103
Open
justcarlson wants to merge 1 commit into
Open
justcarlson wants to merge 1 commit into
justcarlson wants to merge 1 commit into
Conversation
|
I experienced intermittent loss of Super shortcuts and observed Hyprland in the I applied the monitor-disconnect change locally and tested with a headless output. With the launcher open on that output, removing it closed the launcher and returned Hyprland to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the launcher's monitor goes away while the launcher is open (a dock drops, a cable is pulled), Hyprland stays in the
omacastsubmap and every global bind is dead untilomarchy-shell omacast hide. The surface never comes back either: on main, the next open reportsisOpentrue with 0omacastlayers, so the launcher is invisible and holds the submap again. Fixes #102.Quickshell.screenschanges, if the pinned screen is gone, setmapped = falseso the next open maps a fresh surface, and dismiss if shown. The existingonShownChangedpath then resets the submap and cleans up, the same as Esc.SPEC.md§2.0: the "mapped fresh on every open" line was stale; it now says the surface stays mapped and is remapped after a move or a lost monitor.The proposal in #102 also cleared
pinnedScreen. That is not needed:focusedScreen()pins a live screen on the next open. Dismissing alone is not enough: with it, the reopened launcher stays invisible (0 layers), somapped = falseis the part that matters.Checked on Hyprland 0.56.2 and Quickshell 0.3.2, with a headless output as the lost monitor:
isOpenfalse and submapdefault; reopen gives 1 layer and submapomacast; close givesdefault.node --test tests/*.test.js(184 pass),omarchy plugin validate .(exit 0),qs logshows no omacast errors.Not checked:
tests/smoke.shlatency: it fails on my machine both on main (318 / 312 ms worst) and with this patch (345 / 328 ms), so it says nothing about this change.Council review
Rounds: 2
Created with Claude Opus 5.5 in Claude Code.