Repository navigation
Conversation
- Add Bookmarks core module to parse Chromium-based browser bookmarks - Auto-detect Brave, Chrome, Chromium, Vivaldi, and Edge bookmark stores - Add BookmarkSource QML service with live FileView file watching - Scope bookmarks search exclusively to 'b ' / 'B ' prefix in RootSearch - Keep bookmark candidates isolated from general search to ensure zero overhead - Fast-path searchAsync to bypass nativeSearch for bookmark queries - Add 'Open in Browser' (↵) and 'Copy URL' (Ctrl+Shift+C) actions - Support setQuery outcome in LauncherWindow - Add comprehensive unit tests in tests/bookmarks.test.js (192 passing) - Update README.md documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sequenceDiagram participant User participant Launcher as LauncherWindow / RootSearch participant Backend as Backend / BookmarkSource participant Browser as Browser Process User->>Launcher: types "b <query>" Launcher->>Backend: searchAsync("b <query>") Note over Backend: Bypasses nativeSearch (apps index)<br/>Queries isolated BookmarkSource Backend-->>Launcher: Browser Bookmarks results User->>Launcher: presses ↵ (Open in Browser) or Ctrl+Shift+C (Copy URL) Launcher->>Browser: omarchy-launch-browser <url>Adds native browser bookmark search to
oma-cast:borBin the launcher immediately queries browser bookmarks.backend.candidatesandnativeSearch, ensuring general desktop search incurs zero overhead regardless of bookmark count.omarchy-shell.↵opens the bookmark viaomarchy-launch-browser, andCtrl+Shift+Ccopies the URL to the clipboard.Evidence
Before:
Typing
bonly matched web fallbacks or general fuzzy candidates; no bookmark search or browser integration existed.After:
Typing
borb <query>lists and fuzzy-ranks browser bookmarks with instant response. Unit tests and doctor pass:omacast doctorreports all checks ok:Merge Danger
Door: Two-way
All bookmark logic is additive and strictly isolated to the
bsearch prefix. If a browser bookmarks file is absent or malformed,BookmarkSourcesafely falls back to an empty candidate list without throwing or affecting desktop search.Blast Radius: Low
Only affects candidate aggregation and adds the prefix handler for
b. General search, calculator, clipboard, and script runner paths remain unchanged.