Skip to content

fix(ruff): fail fix() when ruff exits with an error code instead of silently returning an empty Changeset #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielgafni merged 1 commit into from
Oct 11, 2026
Merged

fix(ruff): fail fix() when ruff exits with an error code instead of silently returning an empty Changeset #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ruff/src/ruff/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ async def fix(
output = await result.combined_output()
if output.strip():
sys.stderr.write(output)
exit_code = await result.exit_code()
if exit_code not in (0, 1):
raise RuntimeError(
f"`ruff check --fix` failed with exit code {exit_code}: "
"ruff reported an error (configuration, usage, or runtime). "
"See stderr above for ruff's output."
)
before = dag.directory().with_directory(".", source)
fixed = result.directory("/work").without_directory(".ruff_cache")
after = dag.directory().with_directory(".", fixed)
Expand Down
7 changes: 7 additions & 0 deletions ruff/src/ruff/formatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ async def fix(
output = await result.combined_output()
if output.strip():
sys.stderr.write(output)
exit_code = await result.exit_code()
if exit_code not in (0, 1):
raise RuntimeError(
f"`ruff format` failed with exit code {exit_code}: "
"ruff reported an error (configuration, usage, or runtime). "
"See stderr above for ruff's output."
)
before = dag.directory().with_directory(".", source)
fixed = result.directory("/work").without_directory(".ruff_cache")
after = dag.directory().with_directory(".", fixed)
Expand Down
Loading