Add support for :writedata/:file options -- write body directly to a file#100
Open
baconz wants to merge 3 commits intotyphoeus:masterfrom
Open
Add support for :writedata/:file options -- write body directly to a file#100baconz wants to merge 3 commits intotyphoeus:masterfrom
baconz wants to merge 3 commits intotyphoeus:masterfrom
Conversation
These options take a file path as a string, and will write the body of the response directly to the passed path, instead of pulling it into the heap. When passed, these options set :writefunction to NULL, so that Curl knows to write directly to a file. Easy manages the file handle, and closes it automatically in on_complete.
Member
|
thanks for your work @baconz! I will go through it as soon as I have time! :) |
Author
|
Cool, sounds good. Looks like there's a problem on ruby 1.8 -- I'll check it out later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managing the open file handles on easy isn't the greatest, but I'm not sure of another way to make this work, and it is a very handy feature to have.
Totally open to suggestions for improvements, and I can understand it if you think that this does not belong in such a light wrapper.