Drop shebang from test server#256
Open
voxik wants to merge 1 commit intotyphoeus:masterfrom
Open
Conversation
The `spec/support/server.rb` file does not have executable bit set, therefore the shebang is useless.
Contributor
|
Related to the test server, there is also a Lines 30 to 37 in 0e80211 which is not working anymore. Can it be dropped? |
Contributor
Author
It likely can. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
spec/support/server.rbfile does not have executable bit set, therefore the shebang is useless. Other option could be to add the executable bit and store it in repo.And of course, the last option could be that setting the executable bit explicitly when needed is the right way to go. In that case, please feel free to ignore this PR and sorry for the noise.