Remove redundant encoding and require_relative check#258
Merged
felipedmesquita merged 2 commits intotyphoeus:masterfrom Aug 22, 2025
Merged
Remove redundant encoding and require_relative check#258felipedmesquita merged 2 commits intotyphoeus:masterfrom
felipedmesquita merged 2 commits intotyphoeus:masterfrom
Conversation
This magic comment is not needed anymore because the default encoding of source code files assumed by Ruby 2 is utf-8, and the minimum required Ruby version is 2.6 Auto-fixed via: ``` rubocop -a --only Style/Encoding ```
Contributor
Author
|
Failures are still unrelated As I mentioned in #241 , I've experienced several segmentation faults back at the time |
`require_relative` has been introduced in Ruby 1.9.2
Member
|
Thanks, @tagliala! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This magic comment is not needed anymore because the default encoding of source code files assumed by Ruby 2 is utf-8, and the minimum required Ruby version is 2.6
Auto-fixed via:
require_relativehas been introduced in Ruby 1.9.2 and is available in all supported Ruby versions