Skip to content

Remove redundant encoding and require_relative check#258

Merged
felipedmesquita merged 2 commits intotyphoeus:masterfrom
tagliala:chore/remove-old-code
Aug 22, 2025
Merged

Remove redundant encoding and require_relative check#258
felipedmesquita merged 2 commits intotyphoeus:masterfrom
tagliala:chore/remove-old-code

Conversation

@tagliala
Copy link
Copy Markdown
Contributor

@tagliala tagliala commented Aug 22, 2025

This magic comment is not needed anymore because the default encoding of source code files assumed by Ruby 2 is utf-8, and the minimum required Ruby version is 2.6

Auto-fixed via:

rubocop -a --only Style/Encoding

require_relative has been introduced in Ruby 1.9.2 and is available in all supported Ruby versions

This magic comment is not needed anymore because the default encoding of
source code files assumed by Ruby 2 is utf-8, and the minimum required
Ruby version is 2.6

Auto-fixed via:

```
rubocop -a --only Style/Encoding
```
@tagliala
Copy link
Copy Markdown
Contributor Author

Failures are still unrelated

Pending: (Failures listed here are expected and do not affect your suite's status)
/Users/runner/work/ethon/ethon/vendor/bundle/ruby/2.7.0/gems/ffi-1.17.2-arm64-darwin/lib/ffi/autopointer.rb:152: [BUG] Segmentation fault at 0x0000000000000020

As I mentioned in #241 , I've experienced several segmentation faults back at the time

`require_relative` has been introduced in Ruby 1.9.2
@tagliala tagliala changed the title Remove redundant encoding Remove redundant encoding and require_relative check Aug 22, 2025
@felipedmesquita
Copy link
Copy Markdown
Member

Thanks, @tagliala!

@felipedmesquita felipedmesquita merged commit ea5e17f into typhoeus:master Aug 22, 2025
58 of 60 checks passed
@tagliala tagliala deleted the chore/remove-old-code branch August 22, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants