Add logger to runtime dependencies#259
Merged
felipedmesquita merged 1 commit intotyphoeus:masterfrom Aug 23, 2025
Merged
Conversation
Starting from Ruby 3.5, `logger` will no longer be part of the bundled gems. How to replicate: ``` $ ruby --version ruby 3.5.0dev (2025-06-15T04:41:29Z master c88c2319a8) +PRISM [arm64-darwin24] $ ruby -e "require_relative 'lib/ethon'" /path/to/ruby/did_you_mean/core_ext/name_error.rb:11: warning: logger is not part of the default gems since Ruby 3.5.0. Install logger from RubyGems. <internal:/path/to/ruby/rubygems/core_ext/kernel_require.rb>:136:in 'Kernel#require': cannot load such file -- logger (LoadError) ``` Close typhoeus#242
tagliala
force-pushed
the
feature/242-add-logger
branch
from
8a90287 to
304596e
Compare
Contributor
Author
|
Segfault, failure is still unrelated |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from Ruby 3.5,
loggerwill no longer be part of the bundled gems.How to replicate:
Close #242