Skip to content

Show removal results with the approval and serialize worktree removal - #77

Merged
tzarebczan merged 1 commit into
mainfrom
fix/ci-removal-rows-and-worktree-lock
Oct 17, 2026
Merged

tzarebczan merged 1 commit into
mainfrom
fix/ci-removal-rows-and-worktree-lock

Conversation

@tzarebczan

Copy link
Copy Markdown
Owner

Summary

  • The review sheet painted the approval summary as soon as the call returned, while a row could still say Removing until the next list push. Approving now pushes the decided list before the call returns. This is the macOS failure in the push to main after Improve artifact classification and separate VM and installer storage #76 (renderer.agentRemovals.ioBudget.test.ts: expected "Moved to the Trash", got "Removing…").
  • git worktree remove locks the repository index. Removing many worktrees of one repo at once made one clean worktree come back not removed on Windows (main.devWorktreeCheck.ioBudget.test.ts: 8 ok, expected 9). Removals of the same repo now wait their turn. Different repos still run together.
  • No changelog edit and no version bump.

Test plan

  • bun x vitest run src/shared/__tests__/gitWorktreeRemoval.test.ts src/__tests__/renderer.agentRemovals.ioBudget.test.ts src/__tests__/main.devWorktreeCheck.ioBudget.test.ts src/mcp/__tests__/removalReview.test.ts src/mcp/__tests__/removalQueue.test.ts
  • bun x tsc --noEmit
  • CI on this PR, including vitest on macOS and Windows

…orktrees one at a time.

The review sheet painted the approval summary as soon as the call returned, while a row could still say Removing until the next coalesced push. The approval now pushes the decided list before it returns.

Parallel git worktree remove on one repository locks that repo's index, so one clean worktree came back not removed. Removals of the same repo wait their turn. Different repos still run together.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T19:58:24.547664Z 5067640 PR opened
🔒 Security Review ✅ Completed 2026-10-17T19:59:51.650716Z 5067640 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tzarebczan
tzarebczan merged commit 0b0209b into main Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant