Repository navigation
Show removal results with the approval and serialize worktree removal - #77
Merged
Merged
Conversation
…orktrees one at a time. The review sheet painted the approval summary as soon as the call returned, while a row could still say Removing until the next coalesced push. The approval now pushes the decided list before it returns. Parallel git worktree remove on one repository locks that repo's index, so one clean worktree came back not removed. Removals of the same repo wait their turn. Different repos still run together.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderer.agentRemovals.ioBudget.test.ts: expected "Moved to the Trash", got "Removing…").git worktree removelocks the repository index. Removing many worktrees of one repo at once made one clean worktree come back not removed on Windows (main.devWorktreeCheck.ioBudget.test.ts: 8 ok, expected 9). Removals of the same repo now wait their turn. Different repos still run together.Test plan
bun x vitest run src/shared/__tests__/gitWorktreeRemoval.test.ts src/__tests__/renderer.agentRemovals.ioBudget.test.ts src/__tests__/main.devWorktreeCheck.ioBudget.test.ts src/mcp/__tests__/removalReview.test.ts src/mcp/__tests__/removalQueue.test.tsbun x tsc --noEmit