Repository navigation
Keep eight Private Cloud compact-block batches in flight - #60
Merged
Merged
Conversation
The prefetch count was already eight, and the 256 MiB reservation stopped the fifth batch from starting. Eight batches are two 500-block posts each, which fills the gateway's 16 block permits. Combined transparent scans stay at four batches and the ordinary cap.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Private Cloud compact-block prefetch already asks for eight batches. The 256 MiB reservation only let four of those batches start, so the web client kept eight posts in flight against a gateway that allows sixteen.
This raises the reservation to 512 MiB only when the transport is private-cloud and the prefetch width is eight. Each batch is two 500-block posts, which fills the sixteen block permits. Combined transparent scans stay at four batches and the ordinary 256 MiB cap. Other transports keep the existing cap.
Test plan
node --test packages/sdk/test/prefetch.test.ts(includes the eight-range reservation case)