Conversation
* introducing lrpc::byte iso LRPC_BYTE_TYPE * Added tests for encoding/decoding etl::byte and std::byte in EtlRwExtensions.hpp. By virtue of etl::byte and std::byte being an enum class, this was already supported, but there were no tests
* Added test file for etl::byte
* Added byte_type settings
* Fix default byte type in tests
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* Add news fragment * Add support for overlays
* Add mergedeep dependency
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Raw definition dict is immutable * Added overlay_merge * Using TextIOWrapper iso TextIO
* Removed dependency on mergedeep * lrpcg has single option for all types of overlays * Some refactoring
| self._add_from_file(def_file) | ||
|
|
||
| def _add_from_file(self, def_file: TextIO) -> None: | ||
| self._definition = merge_definition(self._definition, self._load_from_file(def_file)) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0201: Attribute '_definition' defined outside init (attribute-defined-outside-init)
* Removed duplicate test * Added new, missing tests * Fixed bug
|
1 participant
❇️ @coderabbitai
Description
Fixes issue #195
@coderabbitai summary
Type