Experiment with a custom Kysely SQLite dialect#680
Draft
goto-bus-stop wants to merge 10 commits intodefaultfrom
Draft
Experiment with a custom Kysely SQLite dialect#680goto-bus-stop wants to merge 10 commits intodefaultfrom
goto-bus-stop wants to merge 10 commits intodefaultfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
June 2025 update: This is probably not necessary for now. Synchronous SQLite with good indexes shouldn't really be an issue for a typical small-scale server. It's not great that it blocks the main thread, but it's not the most urgent problem either.
In particular:
This has one big downside for the tests: connection pooling prevents using a named in-memory store with
better-sqlite3.To explore: