rename the webview and add cromite icons to it

[silentJET85]

Description

This renames the webview package from com.android.webview to org.cromite.webview, which some people have requested, such as in #1760. The display name is changed from Android System WebView to Cromite System WebView.
It also adds the Cromite icons to the Webview, so it no longer uses the generic icon.

All submissions

• there are no other open Pull Requests for the same update/change
• Bromite can be built with these changes
• I have tested that the new change works as intended (AVD or physical device will do)

Format

• patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)

• patch description contains explanation of changes
  (I modified an existing patch, but didn't change it's description. These changes seem to fit in with the patch's purpose.)

• no unnecessary whitespace or unrelated changes

It's worth noting that installing WebViews as a user app with the overlay method, no longer works in Android 15+.
Until someone finds a new method, you have to install it as a system app.
I installed mine in /system/priv-app/CromiteWebView/SystemWebView.apk for example.

[ahmed-alnassif]

You could create a magisk module and install it systemless instead of mod the system

[nekomakia]

just use magisk module from rootalith, you can replace cromite webview old apk from module into newest cromite webview apk.

[uazo]

Thanks! I’ll take a look at your changes and let you know.

[lss4]

It's worth noting that installing WebViews as a user app with the overlay method, no longer works in Android 15+. Until someone finds a new method, you have to install it as a system app. I installed mine in /system/priv-app/CromiteWebView/SystemWebView.apk for example.

Which Android version are you using for this screenshot? If this is on a device with Android 15 or above I'm curious of the content of its config_webview_packages.xml inside the ROM's framework-res.apk (the original, not from any overlay).

From my experience on my device with Android 15+ is that, while the system reports config_webview_packages.xml being modified by overlays (per cmd overlay lookup --verbose --user 0 android android:xml/config_webview_packages), the modified config_webview_packages.xml does not actually take effect as dumpsys webviewupdate reports only what was inside the original file from framework-res.apk.

Should point out that even now (A15+), most ROMs keep a default, AOSP upstream version of config_webview_packages.xml inside framework-res.apk, and ship a framework-res__<insert_rom_and_device_name_here>__auto_generated_rro_product.apk overlay that contains an enriched config_webview_packages.xml additionally including Google's WebView and Chrome variants on top of AOSP WebView, and this also doesn't take effect. As such, Google WebView or Chrome variants will not be listed as options for WebView in such ROMs.

[silentJET85]

@lss4 LineageOS. I think it was version 23.0.

[lss4]

@lss4 LineageOS. I think it was version 23.0.

Okay... so did you install any additional overlay that added your renamed WebView package entry into config_webview_packages.xml?

Or it's just you installed it as a system app and it automatically showed up in the WebView Implementation list in Developer Options, without doing anything else?

[silentJET85]

Yes, the overlay is still needed. I used a modified version of the Bromite overlay with Cromite added to the list.

[lss4]

Yes, the overlay is still needed. I used a modified version of the Bromite overlay with Cromite added to the list.

Okay... if this works on your LOS23.0 (which should be Android 16)... I do worry the issue I'm having with Android 15+ on my device (Edge 20 Pro/pstar) regarding WebView overlay is probably due to something else and does not affect everyone... though I was not the only one having the issue.