Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kevinxiao27
reviewed
Jul 20, 2026
kevinxiao27
left a comment
Member
There was a problem hiding this comment.
doesn't seem like a real issue and zod schema is likely enough
jaykbpark
force-pushed
the
agent/prevent-negative-event-values
branch
from
September 7, 2026 23:05
dc97518 to
1e1ac8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The event form's numeric controls and schema allowed count-like and price values to become negative.
Impact
Invalid negative values are blocked by the UI where possible and rejected by form validation before submission.
Validation
npm run lint(passes with pre-existing warnings)git diff --check