Added SSR prefetching on event homepage - #465
Open
sakiyamadev wants to merge 1 commit into
Open
sakiyamadev wants to merge 1 commit into
sakiyamadev wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sakiyamadev
force-pushed
the
shun/SSR-event-dashboard
branch
from
July 24, 2026 08:18
302476f to
1c70663
Compare
elijahzhao24
left a comment
elijahzhao24
left a comment
Member
There was a problem hiding this comment.
This feels more complex than the ticket requires. The goal is only to prevent the event and registration status from flickering on initial load.
Could we simplify this by fetching the event, current user, and matching registration in getServerSideProps, then passing event, counts, signedIn, and registration directly to EventHomePage props?
Side note:
it seems to be a bit slow on the performance side cause i think you are sequentially fetching event, user, and registrations data. (when it can be fetched at the same time).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The homepage would show checking status for a few seconds whenever the page reloads/initial load. Thus, now the client side pre-fetches the data so on load, the actual status will show immediately.
Issue ticket number and link
UBC-46
https://linear.app/ubc-biztech/issue/UBC-46/add-ssr-for-event-homepage-specifically-event-registration-widget
Checklist before requesting a review
Images / Video of Feature