Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jaykbpark
force-pushed
the
fix/admin-event-open-performance
branch
from
September 7, 2026 23:05
3f7d958 to
964008c
Compare
kevinxiao27
reviewed
Sep 7, 2026
Member
There was a problem hiding this comment.
if ur gonna get ur guy to go through the hassle of writing frontend tests - can you at least set it up to run in CI 😭
kevinxiao27
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening an event from Manage Events currently waits for the registrations and event APIs inside
getServerSideProps, so the user stays on the event list until both finish. The destination then requests the same event details again to build its table columns.This change returns the route shell immediately after the existing middleware check, fetches registrations with the signed-in session and public event details in parallel in the browser, and builds columns from that single event response. Teams, Analytics, and Feedback are loaded when their tabs render. Failed requests show Retry, and switching events clears the previous table and ignores late responses.
Validation:
node --test tests/admin-event-loading.test.cjspasses; the same test fails on unchanged main because route props wait for the backend.autoreview --mode local --no-web-search) is clean after requiring an authenticated initial registration request./btxpage data with the same Redux Toolkit ESM/module-status error under Node 22. The full production build therefore remains blocked..next/build-manifest.jsonafter compilation, before the unrelated collection failure. Shared/cached chunks and network conditions affect actual navigation time.Dependency setup:
npm ciis blocked by platform entries missing from the existing lockfile; local checks used the already-installed dependencies from the feedback-grid checkout.Screenshot
Local capture with API responses held pending, showing the page while registration data loads.