Skip to content

Open admin events without waiting for registration data - #505

Open
jaykbpark wants to merge 1 commit into
devfrom
fix/admin-event-open-performance
Open

jaykbpark wants to merge 1 commit into
devfrom
fix/admin-event-open-performance

Conversation

@jaykbpark

@jaykbpark jaykbpark commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Opening an event from Manage Events currently waits for the registrations and event APIs inside getServerSideProps, so the user stays on the event list until both finish. The destination then requests the same event details again to build its table columns.

This change returns the route shell immediately after the existing middleware check, fetches registrations with the signed-in session and public event details in parallel in the browser, and builds columns from that single event response. Teams, Analytics, and Feedback are loaded when their tabs render. Failed requests show Retry, and switching events clears the previous table and ignores late responses.

Validation:

  • node --test tests/admin-event-loading.test.cjs passes; the same test fails on unchanged main because route props wait for the backend.
  • TypeScript and targeted ESLint pass.
  • AutoReview (autoreview --mode local --no-web-search) is clean after requiring an authenticated initial registration request.
  • Headless Chrome page-boundary checks pass for pending APIs, alternate registration answers, no duplicate event fetch, failure/retry, empty registrations, event switching, late responses, and deferred tabs. These use controlled API responses and child-component stubs, not production timing measurements.
  • Both the branch and unchanged main compile, then fail collecting /btx page data with the same Redux Toolkit ESM/module-status error under Node 22. The full production build therefore remains blocked.
  • Compiled route dependency chunks total 1,400,919 → 1,237,184 gzip bytes (about 160 KiB / 11.7% less); measured from .next/build-manifest.json after compilation, before the unrelated collection failure. Shared/cached chunks and network conditions affect actual navigation time.

Dependency setup: npm ci is blocked by platform entries missing from the existing lockfile; local checks used the already-installed dependencies from the feedback-grid checkout.

Screenshot

Local capture with API responses held pending, showing the page while registration data loads.

Event page loading state

@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
biztech-v2 Ready Ready Preview Sep 7, 2026 11:10pm UTC

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ur gonna get ur guy to go through the hassle of writing frontend tests - can you at least set it up to run in CI 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants