Conversation
|
LGTM - pay attention to merge order. Also, fix the failing pr rule |
jaykbpark
force-pushed
the
feat/feedback-rating-grid
branch
from
September 7, 2026 23:05
6b9fe4a to
41d620f
Compare
kevinxiao27
reviewed
Sep 7, 2026
kevinxiao27
reviewed
Sep 7, 2026
kevinxiao27
reviewed
Sep 7, 2026
jaykbpark
force-pushed
the
feat/feedback-rating-grid
branch
from
September 8, 2026 00:50
41d620f to
ed962d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store each feedback grid as one question with
grid.rowsandgrid.columns, replacing duplicated per-row grouping metadata. Answers remain flat and keyed by stable row IDs.AGENTS.mdguidance on simple data shapes, boundary validation, readable guards, documentation and existing test conventions.Contract
Verification
Rollout
Deploy this API PR before frontend PR #504, which uses the new question type. No production form or response was changed.