Skip to content

chore: gate event feedback submit and admin-only the registrant dump - #778

Merged
liuisaac merged 1 commit into
devfrom
security/gate-events
Sep 14, 2026
Merged

liuisaac merged 1 commit into
devfrom
security/gate-events

Conversation

@liuisaac

Copy link
Copy Markdown
Contributor

POST feedback requires a signed-in user and records identity from the token; GET events/{id}/{year}?users=true now requires admin. Public event view unchanged.

@liuisaac liuisaac changed the title Gate event feedback submit and admin-only the registrant dump chore: gate event feedback submit and admin-only the registrant dump Sep 13, 2026

@jaykbpark jaykbpark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping but maybe remove the comments

Comment thread services/events/handler.ts Outdated
}

const respondentEmail = normalizeText(data.respondentEmail).toLowerCase();
// Identity comes from the verified caller, never a body-supplied value.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob can remove

Comment thread services/events/handler.ts Outdated
const response = helpers.createResponse(200, counts);
return response;
} else if (queryString && queryString.users === "true") {
// This branch batch-returns full user records of every registrant (PII).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob can remove comment

@liuisaac liuisaac closed this Sep 14, 2026
@liuisaac
liuisaac force-pushed the security/gate-events branch from a832644 to 4140590 Compare September 14, 2026 01:06
@liuisaac liuisaac reopened this Sep 14, 2026
@liuisaac

Copy link
Copy Markdown
Contributor Author

comments removed, merging

@liuisaac
liuisaac force-pushed the security/gate-events branch from 356ae4a to 1c7ddb0 Compare September 14, 2026 01:10
@liuisaac
liuisaac merged commit f08c90e into dev Sep 14, 2026
3 checks passed
@liuisaac
liuisaac deleted the security/gate-events branch September 14, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants