Skip to content

refactor(stovepipe): Simplify process admission - #1018

Closed
prathshenoy wants to merge 1 commit into
prath/request-build-associationfrom
prath/process-admission-cleanup
Closed

prathshenoy wants to merge 1 commit into
prath/request-build-associationfrom
prath/process-admission-cleanup

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

What:

  • Keep admission checks and state changes together in a single flow.
  • Share build handoff between initial admission and processing retries without changing behavior.

Why:

  • Keep initial delivery and retry behavior consistent. Both must record and announce the validation start before dispatching its build, but currently duplicate that sequence.
  • Make admission order easier to follow. The existing single-use wrapper passes the same request and queue state to another function without providing a separate responsibility.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert the dependent ordering change first, then revert this PR. The refactor changes no stored data or message contracts.

Issue Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant