Skip to content

ci: zip darwin binaries before notarizing (apple rejects bare mach-o) #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uberware merged 1 commit into from
Jun 25, 2026
Merged

ci: zip darwin binaries before notarizing (apple rejects bare mach-o) #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,18 +195,25 @@ jobs:
MACOS_CERT_PASSWORD_FILE: ${{ steps.macsign_check.outputs.enabled == 'true' && format('{0}/cert.pass', runner.temp) || '' }}

# Notarize the signed darwin binaries. goreleaser leaves each built binary
# under dist/<id>_darwin_<arch>*/; submit each so Gatekeeper accepts them.
# under dist/<id>_darwin_<arch>*/. Apple's notary service only accepts
# containers (.zip/.dmg/.pkg/.app), not bare Mach-O executables, so each
# signed binary is zipped before submission. Stapling is not possible for a
# bare binary/zip; the submission still registers the code-signature hash
# with Apple so Gatekeeper accepts the extracted binary via its online check.
- name: Notarize macOS binaries
if: ${{ steps.macsign_check.outputs.enabled == 'true' }}
run: |
set -euo pipefail
shopt -s nullglob
for bin in dist/sqi-*_darwin_*/sqi-server dist/sqi-*_darwin_*/sqi-worker; do
echo "Notarizing $bin"
zippath="$RUNNER_TEMP/$(echo "$bin" | tr '/' '_').zip"
zip -j "$zippath" "$bin" >/dev/null
rcodesign notary-submit \
--api-key-file "$RUNNER_TEMP/notary-key.json" \
--wait \
"$bin"
"$zippath"
rm -f "$zippath"
done

# ── Python client (sqi-sdk) distributions ──────────────────────────────
Expand Down