This repository was archived by the owner on Jan 22, 2022. It is now read-only.
Merged
Conversation
kugiigi
force-pushed
the
xenial_-_downloadsux
branch
from
ddebb19 to
4bade90
Compare
UniversalSuperBox
suggested changes
Jan 29, 2021
Member
UniversalSuperBox
left a comment
UniversalSuperBox
left a comment
There was a problem hiding this comment.
This PR appears to conflict on DownloadDelegate.qml... Could you rebase it and resolve that conflict? At the moment it isn't testable due to the Oxide removal...
Contributor
Author
|
@balcy Is your commit already what Dalton requested? Do I still need to do something here? |
Collaborator
|
yes it was the merge conflict |
UniversalSuperBox
suggested changes
Feb 2, 2021
Member
UniversalSuperBox
left a comment
UniversalSuperBox
left a comment
There was a problem hiding this comment.
This seems to work well on tablet and mobile usecases, but I've found a few issues.
src/app/SimpleDownloadDelegate.qml
Outdated
| @@ -0,0 +1,164 @@ | |||
| /* | |||
| * Copyright 2015-2016 Canonical Ltd. | |||
Member
There was a problem hiding this comment.
Files that you're creating should at least have a current copyright date, either for yourself or for the UBports Foundation if you wish to assign your copyright to us.
Contributor
Author
There was a problem hiding this comment.
I've updated it to UBports and also to 2021
Updated copyright text and restored UrlUtils
UniversalSuperBox
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally from #336