Add a workflow to report (issue & PR) queue status#497
Conversation
j5awry
left a comment
j5awry
left a comment
There was a problem hiding this comment.
approving -- the comments are non-blocking and things we can consider and iterate on.
| Formatted Markdown string. | ||
| """ | ||
| today = datetime.now(timezone.utc).strftime("%Y-%m-%d") | ||
| return ( |
There was a problem hiding this comment.
won't block, but a future improvement may be to move this to a markdown file with templating rather than inline block in a return.
minimally sticking it in the config section, and having a default value or something similar would make future changes easier. i know i wouldn't first think to look in a return statement for the entire chunk
| """ | ||
| today = datetime.now(timezone.utc).strftime("%Y-%m-%d") | ||
| return ( | ||
| f"📋 Ubuntu Project Docs — Issue & PR Queue ({today})\n" |
There was a problem hiding this comment.
same as above. without the docstring, i wouldn't have realized this was for Matrix either.
and what happens if we send markdown as plaintext? it seems like most annoying bit is the table formatting. I don't want to overcomplicate the code, so maybe having 2 renderings is fine. but having them be in a config spot still makes more sense to me.
| table_foot = "</tbody></table>" | ||
|
|
||
| return ( | ||
| f"<h2>📋 Ubuntu Project Docs — Issue & PR Queue ({today})</h2>" |
There was a problem hiding this comment.
i wonder if it's better to use a markdown-to-html library and just maintain a plaintext and a markdown version, and trust md -> html works?
i don't like having three strings of the same thing in different formats. we should be able to simplify and automate that somehow.
I couldn't find any discussion about this PR on Matrix, what's the current status re: being able to merge? |
* Python script that gathers info on issue & PR queue status * + sends a message to Canonical Mattermost & Ubuntu Matrix * GH Action workflow to run weekly on Mondays * Brief README
|
@j5awry I believe I addressed your comments. Could you please have another look? |
3 participants
Description
Disclosure: Written in large parts by AI
Checklist
This will be ready for merging upon approval by members of
#devel:ubuntu.comon Matrix.