Skip to content

Quote mirror script path expansions in mirror docs#698

Merged
utkarsh2102 merged 2 commits into
mainfrom
copilot/fix-code-for-review-comments
Jul 9, 2026
Merged

Quote mirror script path expansions in mirror docs#698
utkarsh2102 merged 2 commits into
mainfrom
copilot/fix-code-for-review-comments

Conversation

Copilot AI commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

This updates the two shell script examples in docs/release-team/mirror-scripts.md to address the review-thread feedback about incomplete quoting. The snippets now consistently quote path and rsync arguments so the documented examples align with the stated shell-safety expectations.

  • Archive mirror example

    • Quote BASEDIR in the directory existence check and mkdir -p
    • Quote both RSYNCSOURCE and BASEDIR in the two rsync invocations
    • Quote the full trace-file redirect target
  • Release mirror example

    • Apply the same quoting fixes to the directory check, mkdir -p, rsync, and trace-file redirect
  • Example

    if [ ! -d "${BASEDIR}" ]; then
      mkdir -p "${BASEDIR}" || fatal "Creation of ${BASEDIR} failed."
    fi
    
    rsync ... "${RSYNCSOURCE}" "${BASEDIR}" || fatal "Failed to rsync from ${RSYNCSOURCE}."
    
    date -u > "${BASEDIR}/.trace/$(hostname -f)"
    

Related issue

Addressed via the linked PR review thread.


Checklist

  • I have read and followed the Ubuntu Project contributing guide
  • My pull request is linked to an existing issue (if applicable)
  • I have tested my changes, and they work as expected

Additional notes (optional)

This change is intentionally limited to the two reviewed documentation snippets and does not modify unrelated content on the page.


Thank you for contributing to the Ubuntu Project documentation!

Copilot AI changed the title [WIP] Fix code based on review comments Quote mirror script path expansions in mirror docs Jul 8, 2026
Copilot AI requested a review from utkarsh2102 July 8, 2026 16:09
@utkarsh2102 utkarsh2102 marked this pull request as ready for review July 8, 2026 16:37
@utkarsh2102 utkarsh2102 requested review from ginggs and paride as code owners July 8, 2026 16:37
@github-actions github-actions Bot added the Release team For the attention of the Release team label Jul 8, 2026
@utkarsh2102 utkarsh2102 merged commit b22d1bd into main Jul 9, 2026
3 checks passed
@utkarsh2102 utkarsh2102 deleted the copilot/fix-code-for-review-comments branch July 9, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release team For the attention of the Release team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants