Use new Chisel annotations API#82
Merged
jerryz123 merged 1 commit intoucb-bar:masterfrom Mar 10, 2025
Merged
Conversation
The `ChiselAnnotation` API is going away in Chisel 7. This API was introduced in chipsalliance/chisel#4643 and was released in Chisel 6.7.0.
tymcauley
added a commit
to tymcauley/chipyard
that referenced
this pull request
Mar 9, 2025
16 tasks
Contributor
Author
|
@jerryz123 Seems like CI might have been broken for a bit on this repo, do I need to fix something in this PR, or is this failure expected? |
Collaborator
|
I will take a look
…On Mon, Mar 10, 2025 at 09:15 Tynan McAuley ***@***.***> wrote:
@jerryz123 <https://github.com/jerryz123> Seems like CI might have been
broken for a bit on this repo, do I need to fix something in this PR, or is
this failure expected?
—
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLPAJ7OHZLNLWQYEQ4ZS632TXCBHAVCNFSM6AAAAABYTTKBYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJRGEZDGOBTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: tymcauley]*tymcauley* left a comment (ucb-bar/constellation#82)
<#82 (comment)>
@jerryz123 <https://github.com/jerryz123> Seems like CI might have been
broken for a bit on this repo, do I need to fix something in this PR, or is
this failure expected?
—
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLPAJ7OHZLNLWQYEQ4ZS632TXCBHAVCNFSM6AAAAABYTTKBYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJRGEZDGOBTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
jerryz123
approved these changes
Mar 10, 2025
Collaborator
|
Looks like the CI has been dead for a while... sadly. |
tymcauley
added a commit
to tymcauley/chipyard
that referenced
this pull request
Mar 10, 2025
tymcauley
added a commit
to tymcauley/chipyard
that referenced
this pull request
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ChiselAnnotationAPI is going away in Chisel 7. This API was introduced in chipsalliance/chisel#4643 and was released in Chisel 6.7.0.Resolves #81.