You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review.
Walkthrough
The pull request updates client form labels and asset-page titles, removes selected client dependencies and code, and revises MVC page metadata and report views.
Changes: Client changes
Layer / File(s)
Summary
Update client form labels Keas.Mvc/ClientApp/src/components/Access/AssignAccess.tsx, Keas.Mvc/ClientApp/src/components/Equipment/*, Keas.Mvc/ClientApp/src/components/Keys/*, Keas.Mvc/ClientApp/src/components/People/CreatePerson.tsx, Keas.Mvc/ClientApp/src/components/Workstations/AssignWorkstation.tsx
Several form buttons now display “Save” when creating an item. Assignment forms distinguish new items, assigned items, and unassigned existing items. Related tests use the updated labels.
Set and test asset-page titles Keas.Mvc/ClientApp/src/pages/assets/AssetNav.tsx, Keas.Mvc/ClientApp/src/pages/assets/routes.test.tsx
Asset navigation sets the document title from the active section and restores the prior title during cleanup. Tests check route titles, tab changes, and restoration on unmount.
The layout adds request-derived page and preview URLs, description and social metadata, and a server-rendered copyright year.
Update MVC view titles and home content Keas.Mvc/Views/Confirm/MyStuff.cshtml, Keas.Mvc/Views/Group/*, Keas.Mvc/Views/Home/Index.cshtml, Keas.Mvc/Views/PersonAdmin/UploadPeople.cshtml, Keas.Mvc/Views/Report/*.cshtml, Keas.Mvc/Views/TeamAdmin/*.cshtml
Updates page-title metadata for home, confirmation, import, group report, and report views. The home view adds a welcome banner with help and feedback links.
Revise person team lookup Keas.Mvc/Views/Report/PersonTeamList.cshtml
Adds labeled team sections, administrator tables, email links, and DataTable controls. The view also adds a Reports link and an empty-state message.
ucdavis/Peaks#1402: Changes the key-serial save label and creation test flow also touched here.
ucdavis/Peaks#1401: Changes the equipment duplication button label and tests that locate the action by its label.
Merge Risk: Minimal · up to a6b71
This change mostly updates labels, page titles, metadata and removes unused client code. No concrete merge-blocking risk was identified from the supplied summaries.
Pre-merge checks: 3 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Title check
The title "Cyd/final touches" is vague and generic. It names an author branch prefix and the words "final touches" without describing the change. The changeset is a broad cleanup: removing unused Reac…
Rewrite the title to name the main change. For example: "Remove unused React imports and legacy front-end dependencies" or "Clean up front-end dependencies and update page titles". Choose the change the team considers most important.
Passed checks: 3 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Cyd/final touches" is vague and generic. It names an author branch prefix and the words "final touches" without describing the change. The changeset is a broad cleanup: removing unused React imports and unused parameters, removing jQuery, log4javascript, and stacktrace-js dependencies, deleting logger.ts, keyService.ts, SearchCustomOptions, and PeopleListItem, deleting Bootstrap and Gijgo assets, renaming page titles, and adding a Home banner. None of these is named in the title.
Resolution
Rewrite the title to name the main change. For example: "Remove unused React imports and legacy front-end dependencies" or "Clean up front-end dependencies and update page titles". Choose the change the team considers most important.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: 6668a16b-218f-425e-8f4f-f78ebf784ea8
Commits
Reviewing files that changed from the base of the PR and between a012eb4 and a6b710b.
Files selected for processing: 1
Keas.Mvc/Views/Home/Index.cshtml
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements