Skip to content

easy ADA wins - #1415

Merged
cydoval merged 1 commit into
masterfrom
cyd/ADA
Nov 13, 2026
Merged

cydoval merged 1 commit into
masterfrom
cyd/ADA

Conversation

@cydoval

@cydoval cydoval commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Accessibility

    • Added a skip-to-main-content link and improved keyboard navigation and screen reader support for the site menu and main content.
    • Tags labels now focus their corresponding search fields.
  • Visual Updates

    • Adjusted heading line spacing and refined spacing and typography across the page layout.
  • Tests

    • Added coverage for the mobile menu’s accessible name, initial state, and main-content target.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The change updates Tags label targets in four forms and adjusts shared layout accessibility markup and styling. It adds a test for the navigation toggle and updates line-height classes on home page headings.

Changes: Accessibility and layout

Layer / File(s) Summary
Shared layout and typography
Keas.Mvc/Views/Shared/_Layout.cshtml, Keas.Mvc/ClientApp/src/layoutAccessibility.test.ts, Keas.Mvc/Views/Home/Index.cshtml
The layout adds a skip link and main-content target, moves alerts inside <main>, and updates navigation-toggle labeling and styling. A test checks the toggle’s name, initial expanded state, and controls target. Home page headings gain leading-normal.
Tags label associations
Keas.Mvc/ClientApp/src/components/Access/AccessEditValues.tsx, Keas.Mvc/ClientApp/src/components/Equipment/EquipmentEditValues.tsx, Keas.Mvc/ClientApp/src/components/Keys/KeyEditValues.tsx, Keas.Mvc/ClientApp/src/components/Workstations/WorkstationEditValues.tsx
Each Tags label now targets the existing search control ID.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · up to 64369

This change improves accessibility through label associations, a skip link, and heading line-height tweaks. It carries no identified behavioral risk and is low risk to merge.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title "easy ADA wins" is vague and generic. It does not name the accessibility changes. The changeset adds accessible labels, a skip-to-main-content link, a mobile menu test, and heading class upd… Rewrite the title to name the main accessibility change. For example: "Improve ADA accessibility in layout, navigation, and edit forms" or "Add skip link and fix form label associations for accessibility." Also add a short PR description th…
Passed Passed checks: 3 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "easy ADA wins" is vague and generic. It does not name the accessibility changes. The changeset adds accessible labels, a skip-to-main-content link, a mobile menu test, and heading class updates, so the title points at the right theme (ADA accessibility) but gives no specific detail. The PR description is also empty, so a teammate scanning history cannot tell what changed.

Resolution

Rewrite the title to name the main accessibility change. For example: "Improve ADA accessibility in layout, navigation, and edit forms" or "Add skip link and fix form label associations for accessibility." Also add a short PR description that lists the changes and how they were tested.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 1cbe1347-566a-43d9-8e12-f26fc5c7fe6f
Commits

Reviewing files that changed from the base of the PR and between c6b5106 and 64369ed.

Files selected for processing: 7

  • Keas.Mvc/ClientApp/src/components/Access/AccessEditValues.tsx
  • Keas.Mvc/ClientApp/src/components/Equipment/EquipmentEditValues.tsx
  • Keas.Mvc/ClientApp/src/components/Keys/KeyEditValues.tsx
  • Keas.Mvc/ClientApp/src/components/Workstations/WorkstationEditValues.tsx
  • Keas.Mvc/ClientApp/src/layoutAccessibility.test.ts
  • Keas.Mvc/Views/Home/Index.cshtml
  • Keas.Mvc/Views/Shared/_Layout.cshtml

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@cydoval
cydoval merged commit 3dbf122 into master Nov 13, 2026
4 checks passed
@cydoval
cydoval deleted the cyd/ADA branch November 13, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants