Skip to content

Exclude 'Automated' approvals from human approver lists - #564

Merged
jSylvestre merged 1 commit into
masterfrom
JCS/AutoApproveFix20261016
Oct 16, 2026
Merged

jSylvestre merged 1 commit into
masterfrom
JCS/AutoApproveFix20261016

Conversation

@jSylvestre

@jSylvestre jSylvestre commented Oct 16, 2026 •

Copy link
Copy Markdown
Member
image

Summary by CodeRabbit

  • Bug Fixes
    • Debit recharge receipt emails now exclude approvers recorded as “Automated” from the recipient list, alongside approvers recorded as “System” and accounts with no approver. This applies to receipts handled by both automated payment processing and invoice services. Existing user lookup and handling of other email recipients remain unchanged.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 86857d4d-43cb-40f8-a763-31146ec1a17c
📥 Commits

Reviewing files that changed from the base of the PR and between dba3dbd and 3568ad9.

📒 Files selected for processing: 2
  • src/Payments.Jobs.AutoApprove/Program.cs
  • src/Payments.Mvc/Services/InvoiceService.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The auto-approval job and invoice service now exclude debit-account approvers with the value "Automated" when collecting receipt email recipients. Existing exclusions and recipient handling remain unchanged.

Changes: Receipt Recipient Filtering

Layer / File(s) Summary
Update approver exclusions
src/Payments.Jobs.AutoApprove/Program.cs, src/Payments.Mvc/Services/InvoiceService.cs
Both recipient-selection paths now exclude debit accounts whose approver is "Automated", alongside accounts with no approver or an approver of "System".

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 3568a

Automated approvers are excluded from both receipt CC lists, while eligible approvers and the customer recipient remain unchanged. No actionable merge risk is identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: excluding approvals attributed to "Automated" from human approver lists.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@jSylvestre
jSylvestre merged commit bdb2fc3 into master Oct 16, 2026
5 checks passed
@jSylvestre
jSylvestre deleted the JCS/AutoApproveFix20261016 branch October 16, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants