Skip to content

Deploy test automatically and queue production approval - #565

Merged
srkirkland merged 5 commits into
masterfrom
srk/automatic-test-approved-prod
Oct 16, 2026
Merged

srkirkland merged 5 commits into
masterfrom
srk/automatic-test-approved-prod

Conversation

@srkirkland

@srkirkland srkirkland commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Pushes to master now build, test, and deploy to test. After test deployment and health checks succeed, production waits for approval in the same CI/CD run. Choose Review deployments → prod → Approve and deploy to build, test, and deploy that run's commit to production. A separate manual run is no longer required.

Production requires approval from either srkirkland or a member of @ucdavis/caesdo-devs. Self-approval is allowed, administrator bypass is disabled, and deployments are restricted to master. Failed, cancelled, or incomplete test deployments block the automatic production stage. Manual test/prod runs remain available for targeted retries; manual production still requires approval. Pull requests only validate.

The shared deployment workflow preserves .NET 6, Node 22, Windows hosting, both WebJobs, and the existing publish/ZIP/deploy flow. Production uses its separate App Service-scoped OIDC identity. The runbook covers approval, selecting the intended commit, verification, and rollback; the Azure manual release path remains available.

Validation:

  • Workflow lint and formatting passed.
  • Local evaluation passed 19 routing scenarios and 48 event, branch, and environment guard combinations.
  • Saved GitHub reviewer, self-approval, administrator-bypass, and branch settings were verified read-only.
  • Publish/ZIP and Windows/WebJob package contracts were verified for the unchanged build steps.
  • GitHub CI passed, including frontend tests and all 165 backend tests. All deployment jobs were skipped on the PR.
  • Azure PR test and publish checks passed. CodeRabbit also passed with no inline findings.

No merge or deployment was performed. Hosted approval-wait enforcement and post-deployment acceptance remain deferred to an authorized release.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: c5510c6d-3568-4b6f-86f8-08b7ff5f6348
📥 Commits

Reviewing files that changed from the base of the PR and between 26bee8a and 90f9fb6.

📒 Files selected for processing: 4
  • .github/workflows/ci.yml
  • .github/workflows/deploy.yml
  • README.md
  • docs/test-deployment.md

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The CI/CD workflow validates pull requests, deploys pushes to master to test, and supports manual deployments to test or production. The deployment guide covers environment configuration, approval, release verification, and recovery.

Changes: GitHub Actions deployment

Layer / File(s) Summary
Workflow triggers and reusable deployment
.github/workflows/ci.yml, .github/workflows/deploy.yml
The workflow adds a manual test or prod selection, limits validation to pull requests, and calls the reusable deployment workflow for eligible pushes and manual runs.
Environment configuration and deployment controls
docs/test-deployment.md, README.md
The documentation covers trigger outcomes, build checks, environment values and identities, production approval settings, and Azure release-path controls. The README summarizes test deployment, production approval, verification, and rollback.
Release verification and recovery
docs/test-deployment.md
The guide covers test retries, production release checks, acceptance evidence, and recovery steps for both environments.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant CICD as GitHub Actions CI/CD
  participant Deploy as deploy.yml
  participant Environment as GitHub production environment
  participant Azure as Azure App Service
  CICD->>Deploy: Call reusable workflow with environment
  Deploy->>Environment: Request production approval
  Environment->>Deploy: Allow deployment after approval
  Deploy->>Azure: Authenticate with OIDC and deploy
Loading
Merge Risk: ⚪ Minimal · up to 90f9f

The workflow routes pull requests to validation, master pushes through test before the production job, and manual runs to the selected environment. No concrete merge-blocking issue is evident; production approval and Azure behavior remain to be verified during an authorized release.

Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main changes: automatic test deployment and queued production approval.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@srkirkland srkirkland changed the title ci: automate test deployments and enable manual production releases Automate test deployment and gate production with approval Oct 16, 2026
@srkirkland srkirkland changed the title Automate test deployment and gate production with approval ci: automate test deployments and enable manual production releases Oct 16, 2026
@srkirkland srkirkland changed the title ci: automate test deployments and enable manual production releases ci: automate test deployment before production approval Oct 16, 2026
@srkirkland srkirkland changed the title ci: automate test deployment before production approval Deploy test automatically and queue production approval Oct 16, 2026
@srkirkland
srkirkland merged commit 37373c9 into master Oct 16, 2026
8 checks passed
@srkirkland
srkirkland deleted the srk/automatic-test-approved-prod branch October 16, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant