Conversation
|
Any thoughts @ellieyhcheng - do you think it's a worthwhile idea? Also not sure how you feel about some of the stylistic things (ex line length) |
|
I think it's worthwhile! It has been bothering me a bit, but it wasn't a priority for me to set up. So thank you! I'll probably ask someone on the team to complete the todos you mentioned before merge. |
|
Cool beans!
Sounds good, though I can definitely resolve some of them. One big question on my end - should we be ignoring the migrations/schema in lint? Is this vendored code? Not super familiar with the tech stack here. |
|
Yeah migrations and schema are generated files from flask-alchemy and flask-migrate. They shouldn't need linting, and I'm not sure what might happen if we do try to lint it. |
|
Okay, I feel ridiculous but I can't figure out how to ignore a directory in pylint (have done the cursory SO search and it doesn't work). Will do a bit more later ! |
|
Just going through my own stale PRs, bump @matthewcn56; what do you want to do about this? |
Something on the back of my mind - integrating CI into our non-JS workflows. Pylint might be a good start!
Todo:
Not urgent, merge in when you feel like it 😊