Skip to content

ci: add pylint CI#23

Open
mattxwang wants to merge 5 commits into
mainfrom
pylint-ci
Open

ci: add pylint CI#23
mattxwang wants to merge 5 commits into
mainfrom
pylint-ci

Conversation

@mattxwang

@mattxwang mattxwang commented Jan 27, 2022

Copy link
Copy Markdown
Member

Something on the back of my mind - integrating CI into our non-JS workflows. Pylint might be a good start!

Todo:

  • ignore migrations (and schema?)
  • resolve style errors

Not urgent, merge in when you feel like it 😊

@mattxwang

Copy link
Copy Markdown
Member Author

Any thoughts @ellieyhcheng - do you think it's a worthwhile idea? Also not sure how you feel about some of the stylistic things (ex line length)

@ellieyhcheng

Copy link
Copy Markdown
Contributor

I think it's worthwhile! It has been bothering me a bit, but it wasn't a priority for me to set up. So thank you! I'll probably ask someone on the team to complete the todos you mentioned before merge.

@ellieyhcheng ellieyhcheng linked an issue Jan 27, 2022 that may be closed by this pull request
8 tasks
@mattxwang

Copy link
Copy Markdown
Member Author

Cool beans!

So thank you! I'll probably ask someone on the team to complete the todos you mentioned before merge.

Sounds good, though I can definitely resolve some of them.

One big question on my end - should we be ignoring the migrations/schema in lint? Is this vendored code? Not super familiar with the tech stack here.

@ellieyhcheng

Copy link
Copy Markdown
Contributor

Yeah migrations and schema are generated files from flask-alchemy and flask-migrate. They shouldn't need linting, and I'm not sure what might happen if we do try to lint it.

@mattxwang

Copy link
Copy Markdown
Member Author

Okay, I feel ridiculous but I can't figure out how to ignore a directory in pylint (have done the cursory SO search and it doesn't work). Will do a bit more later !

@mattxwang

Copy link
Copy Markdown
Member Author

Just going through my own stale PRs, bump @matthewcn56; what do you want to do about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve style errors in current files

2 participants