Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDRLoaderThere are few other issues that I would like to fix. The primary issue is how custom
equinoxModulesare defined. AFAIU, it's flexible how you want to do it, but often they are callables (as is the case here). However since this is optional, usingequinox.Moduleas the type is incomplete (and unhelpful). So I implemented aModuleProtocolclass (not in the PR), but that doesn't solve the problem because the different__call__method implementations have incompatible signatures. I don't know the internal details well enough to harmonise this.Other than this, there are some inconsistent use of arrays. The following types are used interchangeably:
list[np.ndarray]np.ndarrayjax.Arrayjax.Arrayis actually wrong as type since it can be a scalar (jaxtyping.Scalar), or an array (jaxtyping.Float[jaxtyping.Array, "..."]or similar).