M5U-34 Added Turnitin Tool Two plugin

[lbailey-ucsf]

No description provided.

[lbailey-ucsf]

@ctam @mirleu

Curious if this is a change in 5.1 where CI fails on phpunit warnings?

[lbailey-ucsf]

@ctam @mirleu

Curious if this is a change in 5.1 where CI fails on phpunit warnings?

I suspect the tests were always non-functional and emitted warnings but our UCSFCLE_501_STABLE branch now includes failOnWarning="true"

How do you think we need to handle this?

[ctam]

I encountered the same type of warnings in Kaltura, and I created an issue on the Kaltura's repo and a PR for the fix.

If the developer is not very responsive, we will have to mirror their repo and apply our fix there with the creation of our own UCSFLCLE_501_STABLE.

[lbailey-ucsf]

The problem here is, they put their tests in a sub-directory, tests/unit. But Moodle requires test to be at the root level tests/.

• If we fork it, we'd have to move tests out of tests/unit and into test/ and edit all 11 failing tests. Ironically, the plugin claims to be be Moodle 5.1 compatible; I suspect the plugin works in M5.1 even with broken unit test semantics.
• I don't see any evidence that our CI ever ran the tests for this plugin in our UCSFCLE_405_STABLE branch; we could exclude the testsuite altogether with a push.yml edit in our UCSFCLE_501_STABLE branch.
• I doubt they will restructure their project between now and when we go live. They seem to have a specific testing procedure.
• We should also consider the fact that the plugin is being retired and replaced with an LTI integration.

[ctam]

Just to circulate back from the discussion at the code fest, are we going to push for replacing this plugin with their LTI counterpart, @mirleu? We might need to let the Service Team know ahead and have time to plan for it.

[lbailey-ucsf]

The tests fail the same way when I try to run them directly; they're just not compatible with Moodle 5.1.

PHPUnit 9 (used by Moodle 4.x) may have allowed test classes to extend advanced_testcase with any class name and the name didn't have to match the filename. But PHPUnit 11 (Moodle 5.1) enforces that the class name in the file must match what it derives from the filename. This plugin's tests were written for PHPUnit 9 conventions and haven't yet been updated for PHPUnit 11.

We need to decide if we want to skip the testsuite, fork-and-fix, or something else.