Skip to content

Conversation

@wingdeans
Copy link
Contributor

@wingdeans wingdeans commented Sep 22, 2025

  • switches from rgb+depth camera to plain rgb camera
  • limits buoyancy calculations to sub

See #270

@wingdeans wingdeans force-pushed the dean-simulation-performance branch from 1fccc84 to 4603446 Compare September 22, 2025 17:16
Carlosdc25
Carlosdc25 previously approved these changes Oct 14, 2025
@wingdeans
Copy link
Contributor Author

Somehow dismissed the review while checking the CI?
Also, were there issues with limiting buoyancy calculations to the sub, or did that get lost in the merge?

@Carlosdc25
Copy link
Contributor

No there weren't any issues it just got lost in the merge

@Carlosdc25
Copy link
Contributor

Although I do predict we might see issues with spanning objects in the future but that shouldn't be too hard to fix

@wingdeans wingdeans requested a review from Carlosdc25 October 23, 2025 19:41
Carlosdc25
Carlosdc25 previously approved these changes Oct 23, 2025
- switches from rgb+depth camera to plain rgb camera
- limits buoyancy calculations to sub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants